Skip to content

Conversation

@BourgoisMickael
Copy link
Contributor

We don't want to disable by default.
But in case a customer has problems with this new limit in S3C,
we want a way to easily disable the limit to give time to customer
to migrate its applications to MPU

@bert-e
Copy link
Contributor

bert-e commented Sep 5, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 5, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-741 contains:

  • 9.0.27

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.27

  • 9.1.1

Please check the Fix Version/s of CLDSRV-741, or the target
branch of this pull request.

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.18%. Comparing base (4124dc5) to head (d8ea3d6).
⚠️ Report is 1 commits behind head on development/9.0.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 79.22% <100.00%> (+0.02%) ⬆️
lib/api/objectPut.js 94.64% <100.00%> (+0.04%) ⬆️
@@               Coverage Diff                @@
##           development/9.0    #5935   +/-   ##
================================================
  Coverage            83.18%   83.18%           
================================================
  Files                  188      188           
  Lines                12103    12105    +2     
================================================
+ Hits                 10068    10070    +2     
  Misses                2035     2035           
Flag Coverage Δ
ceph-backend-test 65.67% <100.00%> (+<0.01%) ⬆️
file-ft-tests 66.04% <100.00%> (+<0.01%) ⬆️
kmip-ft-tests 26.85% <100.00%> (+0.01%) ⬆️
mongo-v0-ft-tests 67.88% <100.00%> (-0.02%) ⬇️
mongo-v1-ft-tests 67.88% <100.00%> (+<0.01%) ⬆️
multiple-backend 35.34% <100.00%> (+0.01%) ⬆️
quota-tests 32.96% <100.00%> (+0.83%) ⬆️
quota-tests-inflights 34.08% <100.00%> (+0.01%) ⬆️
unit 67.28% <100.00%> (+<0.01%) ⬆️
utapi-v2-tests 33.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +1746 to +1749
/**
* S3C-10336: PutObject max size of 5GB is new in 9.5.1
* Provides a way to bypass the new validation if it breaks customer workflows
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* S3C-10336: PutObject max size of 5GB is new in 9.5.1
* Provides a way to bypass the new validation if it breaks customer workflows
*/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is documentation for the flag

We don't want to disable by default.
But in case a customer has problems with this new limit in S3C,
we want a way to easily disable the limit to give time to customer
to migrate its applications to MPU
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-741-bypass-putobj5G branch from e5b9fae to d8ea3d6 Compare September 8, 2025 12:59
@BourgoisMickael
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Sep 9, 2025
@bert-e
Copy link
Contributor

bert-e commented Sep 9, 2025

Conflict

A conflict has been raised during the creation of
integration branch w/9.1/improvement/CLDSRV-741-bypass-putobj5G with contents from improvement/CLDSRV-741-bypass-putobj5G
and development/9.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.1/improvement/CLDSRV-741-bypass-putobj5G origin/development/9.1
 git merge origin/improvement/CLDSRV-741-bypass-putobj5G
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.1/improvement/CLDSRV-741-bypass-putobj5G

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 9, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-741.

Goodbye bourgoismickael.

The following options are set: approve

@bert-e bert-e merged commit d8ea3d6 into development/9.0 Sep 9, 2025
52 of 53 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-741-bypass-putobj5G branch September 9, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants