-
Notifications
You must be signed in to change notification settings - Fork 252
CLDSRV-741: Test iam action version PutRetention & LegalHold #5956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDSRV-741: Test iam action version PutRetention & LegalHold #5956
Conversation
For PutRetention & PutLegalHold Related to ARSN-297
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds test coverage for IAM actions related to object retention and legal hold operations with version IDs, specifically testing that the correct action (s3:PutObjectRetention vs s3:PutObjectVersionRetention) is used for these operations.
- Adds comprehensive test suites to verify IAM action behavior for both retention and legal hold operations
- Updates the
BucketUtility.empty()method to support bypassing governance retention when cleaning up test buckets - Tests verify that standard S3 actions work correctly with version IDs (no longer requiring non-standard versioned actions)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/functional/aws-node-sdk/test/object/putRetention.js | Adds IAM action tests for putObjectRetention with and without version IDs |
| tests/functional/aws-node-sdk/test/object/putObjectLegalHold.js | Adds IAM action tests for putObjectLegalHold with and without version IDs |
| tests/functional/aws-node-sdk/lib/utility/bucket-util.js | Updates empty method to support bypassing governance retention for test cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
❌ 37 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 149 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
|
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-741. Goodbye bourgoismickael. |
Related to ARSN-297