Skip to content

Conversation

@dvasilas
Copy link
Contributor

@dvasilas dvasilas commented Nov 6, 2025

Fixes a bug in the batchDelete backbeat route that was missed when scality/Arsenal#2560 upgraded metadata.getBucket() callback signature to include a third parameter.

The batchDelete route in routeBackbeat.js was not updated when Arsenal
added the raftSessionId parameter to metadata.getBucket() callbacks in
commit 184d37bdd (ARSN-533).

Fixed by adding an intermediate callback that explicitly handles all
3 parameters but only passes the needed 2 to next()
Update test stubs of metadata.getBucket() to include the third
raftSessionId parameter introduced in Arsenal ARSN-533.
@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2025

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-776 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.1.5

Please check the Fix Version/s of CLDSRV-776, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@dvasilas
Copy link
Contributor Author

dvasilas commented Nov 6, 2025

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0

Please check the status of the associated issue CLDSRV-776.

Goodbye dvasilas.

The following options are set: approve

@bert-e bert-e merged commit fad266d into development/9.1 Nov 6, 2025
30 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-776 branch November 6, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants