`lsl_get_xml` is not deterministic.

[cboulay]

I'm using pylsl for my testing, but I don't see how that can be at fault given that I'm just looking at the return of lib.lsl_get_xml(self.obj). Below in the collapsed details are the returns of 5 consecutive calls. Only the 4th appears to be correct. The second seems to have the last few bytes repeated. The others seem to have extra garbage added to the tail.

This is with my own tests in some separate software. I repeated the above with SendDataAdvanced.py, 2/5 were good, the rest had the same junk appended to the tail.

b'<?xml version="1.0"?>\n<info>\n\t<name>Test EEG Stream</name>\n\t<type>EEG</type>\n\t<channel_count>3</channel_count>\n\t<channel_format>double64</channel_format>\n\t<source_id>npype_test_0</source_id>\n\t<nominal_srate>512.0000000000000</nominal_srate>\n\t<version>1.100000000000000</version>\n\t<created_at>34853.85875440000</created_at>\n\t<uid>b0b50389-1801-4027-9883-7616a3be6032</uid>\n\t<session_id>default</session_id>\n\t<hostname>DESKTOP-8HB5T46</hostname>\n\t<v4address />\n\t<v4data_port>16572</v4data_port>\n\t<v4service_port>16572</v4service_port>\n\t<v6address />\n\t<v6data_port>16572</v6data_port>\n\t<v6service_port>16572</v6service_port>\n\t<desc>\n\t\t<manufacturer>UnitTest</manufacturer>\n\t\t<channels>\n\t\t\t<channel>\n\t\t\t\t<label>C3</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>1</X>\n\t\t\t\t\t<Y>-1</Y>\n\t\t\t\t\t<Z>10</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>Cz</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>2</X>\n\t\t\t\t\t<Y>-2</Y>\n\t\t\t\t\t<Z>11</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>C4</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>3</X>\n\t\t\t\t\t<Y>-3</Y>\n\t\t\t\t\t<Z>12</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t</channels>\n\t</desc>\n</info>\ncol\xda\x03hotz\ntheta/beta\xda\x04PRGn\xe7'

b'<?xml version="1.0"?>\n<info>\n\t<name>Test EEG Stream</name>\n\t<type>EEG</type>\n\t<channel_count>3</channel_count>\n\t<channel_format>double64</channel_format>\n\t<source_id>npype_test_0</source_id>\n\t<nominal_srate>512.0000000000000</nominal_srate>\n\t<version>1.100000000000000</version>\n\t<created_at>34853.85875440000</created_at>\n\t<uid>b0b50389-1801-4027-9883-7616a3be6032</uid>\n\t<session_id>default</session_id>\n\t<hostname>DESKTOP-8HB5T46</hostname>\n\t<v4address />\n\t<v4data_port>16572</v4data_port>\n\t<v4service_port>16572</v4service_port>\n\t<v6address />\n\t<v6data_port>16572</v6data_port>\n\t<v6service_port>16572</v6service_port>\n\t<desc>\n\t\t<manufacturer>UnitTest</manufacturer>\n\t\t<channels>\n\t\t\t<channel>\n\t\t\t\t<label>C3</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>1</X>\n\t\t\t\t\t<Y>-1</Y>\n\t\t\t\t\t<Z>10</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>Cz</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>2</X>\n\t\t\t\t\t<Y>-2</Y>\n\t\t\t\t\t<Z>11</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>C4</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>3</X>\n\t\t\t\t\t<Y>-3</Y>\n\t\t\t\t\t<Z>12</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t</channels>\n\t</desc>\n</info>\ns>\n\t</desc>\n</info>\n'

b'<?xml version="1.0"?>\n<info>\n\t<name>Test EEG Stream</name>\n\t<type>EEG</type>\n\t<channel_count>3</channel_count>\n\t<channel_format>double64</channel_format>\n\t<source_id>npype_test_0</source_id>\n\t<nominal_srate>512.0000000000000</nominal_srate>\n\t<version>1.100000000000000</version>\n\t<created_at>34853.85875440000</created_at>\n\t<uid>b0b50389-1801-4027-9883-7616a3be6032</uid>\n\t<session_id>default</session_id>\n\t<hostname>DESKTOP-8HB5T46</hostname>\n\t<v4address />\n\t<v4data_port>16572</v4data_port>\n\t<v4service_port>16572</v4service_port>\n\t<v6address />\n\t<v6data_port>16572</v6data_port>\n\t<v6service_port>16572</v6service_port>\n\t<desc>\n\t\t<manufacturer>UnitTest</manufacturer>\n\t\t<channels>\n\t\t\t<channel>\n\t\t\t\t<label>C3</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>1</X>\n\t\t\t\t\t<Y>-1</Y>\n\t\t\t\t\t<Z>10</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>Cz</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>2</X>\n\t\t\t\t\t<Y>-2</Y>\n\t\t\t\t\t<Z>11</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>C4</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>3</X>\n\t\t\t\t\t<Y>-3</Y>\n\t\t\t\t\t<Z>12</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t</channels>\n\t</desc>\n</info>\nlsrq'

b'<?xml version="1.0"?>\n<info>\n\t<name>Test EEG Stream</name>\n\t<type>EEG</type>\n\t<channel_count>3</channel_count>\n\t<channel_format>double64</channel_format>\n\t<source_id>npype_test_0</source_id>\n\t<nominal_srate>512.0000000000000</nominal_srate>\n\t<version>1.100000000000000</version>\n\t<created_at>34853.85875440000</created_at>\n\t<uid>b0b50389-1801-4027-9883-7616a3be6032</uid>\n\t<session_id>default</session_id>\n\t<hostname>DESKTOP-8HB5T46</hostname>\n\t<v4address />\n\t<v4data_port>16572</v4data_port>\n\t<v4service_port>16572</v4service_port>\n\t<v6address />\n\t<v6data_port>16572</v6data_port>\n\t<v6service_port>16572</v6service_port>\n\t<desc>\n\t\t<manufacturer>UnitTest</manufacturer>\n\t\t<channels>\n\t\t\t<channel>\n\t\t\t\t<label>C3</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>1</X>\n\t\t\t\t\t<Y>-1</Y>\n\t\t\t\t\t<Z>10</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>Cz</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>2</X>\n\t\t\t\t\t<Y>-2</Y>\n\t\t\t\t\t<Z>11</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>C4</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>3</X>\n\t\t\t\t\t<Y>-3</Y>\n\t\t\t\t\t<Z>12</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t</channels>\n\t</desc>\n</info>\n'

b'<?xml version="1.0"?>\n<info>\n\t<name>Test EEG Stream</name>\n\t<type>EEG</type>\n\t<channel_count>3</channel_count>\n\t<channel_format>double64</channel_format>\n\t<source_id>npype_test_0</source_id>\n\t<nominal_srate>512.0000000000000</nominal_srate>\n\t<version>1.100000000000000</version>\n\t<created_at>34853.85875440000</created_at>\n\t<uid>b0b50389-1801-4027-9883-7616a3be6032</uid>\n\t<session_id>default</session_id>\n\t<hostname>DESKTOP-8HB5T46</hostname>\n\t<v4address />\n\t<v4data_port>16572</v4data_port>\n\t<v4service_port>16572</v4service_port>\n\t<v6address />\n\t<v6data_port>16572</v6data_port>\n\t<v6service_port>16572</v6service_port>\n\t<desc>\n\t\t<manufacturer>UnitTest</manufacturer>\n\t\t<channels>\n\t\t\t<channel>\n\t\t\t\t<label>C3</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>1</X>\n\t\t\t\t\t<Y>-1</Y>\n\t\t\t\t\t<Z>10</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>Cz</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>2</X>\n\t\t\t\t\t<Y>-2</Y>\n\t\t\t\t\t<Z>11</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t\t<channel>\n\t\t\t\t<label>C4</label>\n\t\t\t\t<unit>microvolts</unit>\n\t\t\t\t<type>EEG</type>\n\t\t\t\t<location>\n\t\t\t\t\t<X>3</X>\n\t\t\t\t\t<Y>-3</Y>\n\t\t\t\t\t<Z>12</Z>\n\t\t\t\t</location>\n\t\t\t</channel>\n\t\t</channels>\n\t</desc>\n</info>\nt\xd1N\xcf\x01'

[cboulay]

Just confirming that I get the same when debugging ReceiveDataC in VS2019 with SendDataC (Debug) running in the background.

First try:

<?xml version="1.0"?>
<info>
	<name>SendDataC</name>
	<type>EEG</type>
	<channel_count>8</channel_count>
	<channel_format>float32</channel_format>
	<source_id>325wqer4354</source_id>
	<nominal_srate>500.0000000000000</nominal_srate>
	<version>1.100000000000000</version>
	<created_at>36158.48481850000</created_at>
	<uid>c4aa7138-e565-4a8f-bddf-39adea3a3b2b</uid>
	<session_id>default</session_id>
	<hostname>DESKTOP-8HB5T46</hostname>
	<v4address />
	<v4data_port>16572</v4data_port>
	<v4service_port>16572</v4service_port>
	<v6address />
	<v6data_port>16572</v6data_port>
	<v6service_port>16572</v6service_port>
	<desc />
</info>
ÍýýýýÝÝÝÝÝÝÝÝÝÝݴжhðo

Second try

<?xml version="1.0"?>
<info>
	<name>SendDataC</name>
	<type>EEG</type>
	<channel_count>8</channel_count>
	<channel_format>float32</channel_format>
	<source_id>325wqer4354</source_id>
	<nominal_srate>500.0000000000000</nominal_srate>
	<version>1.100000000000000</version>
	<created_at>36158.48481850000</created_at>
	<uid>c4aa7138-e565-4a8f-bddf-39adea3a3b2b</uid>
	<session_id>default</session_id>
	<hostname>DESKTOP-8HB5T46</hostname>
	<v4address />
	<v4data_port>16572</v4data_port>
	<v4service_port>16572</v4service_port>
	<v6address />
	<v6data_port>16572</v6data_port>
	<v6service_port>16572</v6service_port>
	<desc />
</info>
ÍýýýýÝÝÝÝÝÝÝÝÝÝÝǪP>yè

[cboulay]

It appears to be the same strcpy --> memcpy problem as the other recent issue & reversion.

ece288b

In this case I fixed it by setting the final value to '\0'. Seems to be OK so far.