CMake reorganization #128
Merged
CMake reorganization #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porting the lslobj and lslboost targets
Collaborator
|
Thanks for providing the link to the ASIO separate compilation - otherwise I would have been lost as to why that file is only included in the non-optimized build. This looks good. It's all quite straightforward and the checks all pass so I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
target_link_library(lsl PUBLIC lslobj)requiredlslobjto be listed in the exported targets and indirectly added a dependency on pugixml for the Ubuntu builds.This PR links
lslobjprivately tolsl, moves some blocks so the code is easier to read and add theLSL_OPTIMIZATIONSflag to enable some more optimizations that will slow full builds down somewhat and incremental builds even more.