Refactor CMake to make it easier to follow by modularizing concerns #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboulay
force-pushed
the
cboulay/cmake_refactor
branch
4 times, most recently
from
3daa39e to
ed561c8
Compare
cboulay
force-pushed
the
cboulay/cmake_refactor
branch
from
c54bec7 to
052d83a
Compare
… the variable names.
…ast we don't get a big red X.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored CMakeLists.txt into a set of modules. Each module has a specific concern. Maybe my aging brain can't hold as much in working memory as it used to, but IMO this refactor makes it a lot easier to follow what we're doing with CMake. Indeed, it was necessary to do this refactor before I could make progress on building liblsl as an Apple Framework with code signing and notarization (coming in a future PR) so I really would like this PR merged.
This PR does not change the code. As far as I know, I simply moved things around.
I also added a bunch of #TODOs and questions of things I hope to address to further simplify the CMake scripts.
Let's see what the CI runners have to say...