scx_lavd: Correctly measure wake frequency. #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SCX_OPS_ALLOW_QUEUED_WAKEUP is set, wake-up operations are batch-processed in the kernel. Hence, @current is no longer a waker task, so we cannot correctly track the task's wake frequency. So we disable SCX_OPS_ALLOW_QUEUED_WAKEUP for now. Signed-off-by: Changwoo Min <changwoo@igalia.com>
We limit the wake frequency tracking within userspace tasks under the same parent. The kernel tasks are too broadly related. Signed-off-by: Changwoo Min <changwoo@igalia.com>
hodgesds
approved these changes
Jul 5, 2025
Contributor
hodgesds
left a comment
hodgesds
left a comment
There was a problem hiding this comment.
This makes sense, thanks for the good description.
multics69
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SCX_OPS_ALLOW_QUEUED_WAKEUP is set, wake-up operations are batch-processed in the kernel. Hence, @current is no longer a waker task, so we cannot correctly track the task's wake frequency. So we disable SCX_OPS_ALLOW_QUEUED_WAKEUP for now.
Also, we limit the wake frequency tracking within userspace tasks under the same parent. The kernel tasks are too broadly related.