scx_utils, scx_lavd: Harden the futex tracing. #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2025 10:27
When the kernel does not enable the tracepoint, there is no 'available_events' under '/sys/kernel/debug/tracing'. So, let's return 'Ok(false)' in that case. Signed-off-by: Changwoo Min <changwoo@igalia.com>
When the kernel is built without ftrace support, setting the autoload of futex functions using ftrace causes the verifier errors. So, let's check if the kernel supports ftrace before tracing the futex functions. Signed-off-by: Changwoo Min <changwoo@igalia.com>
multics69
requested review from
EricccTaiwan,
arighi,
daidavid,
hodgesds and
htejun
|
Hey, Thanks for looking into it ! Can disabling FTRACE negatively affect performance, I.e. is it used for non-debugging purposes, e.g. tracing processes to get insights on better scheduling decisions ? |
It depends on workloads, of course. If the workload heavily relies on futex, it will help a bit. Otherwise, it shouldn't matter much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When neither tracepoint nor ftrace is enabled by the kernel, the existing futex tracing code raises runtime errors. This PR is to handle such error cases gracefully. It first add a missing error condition check (compat::tracepoint_exists), and check if ftraced is available before attaching ftrace points (compat::tracer_available).
This should resolve the problem reported at Frogging-Family/linux-tkg#1156
Once this is merged, #2914 should be closed.