minor refactor of scx_rusty #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Refactoring LGTM, not very familiar w/ |
Byte-Lab
requested changes
Dec 14, 2023
| stat_add(RUSTY_STAT_DIRECT_DISPATCH, 1); | ||
| } else { | ||
| stat_add(RUSTY_STAT_PINNED, 1); | ||
| } |
Contributor
There was a problem hiding this comment.
I think we can simplify the if on line 442 by removing the first p->nr_cpus_allowed > 1 clause, which should always be true now that we're always doing local dispatching if p->nr_cpus_allowed == 1
Contributor
Author
There was a problem hiding this comment.
Good call. Will fix.
Contributor
|
Looks great, thanks for the cleanup. Just left a comment for one more small cleanup we can do because of this refactor. |
jordalgo
force-pushed
the
minor-rusty-refactor
branch
from
2fb70e8 to
ba35b97
Compare
Byte-Lab
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.