Skip to content

perf: Write directly to file descriptor #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

perf: Write directly to file descriptor #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions src/harfile/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@

HAR_VERSION = "1.2"

_JSON_ENCODER = json.JSONEncoder()


class HarFile:
_fd: IO[str]
Expand Down Expand Up @@ -141,23 +143,37 @@ def add_entry(
separator = "\n" if self._is_first_entry else ",\n"
self._is_first_entry = False
write = self._fd.write
dumps = json.dumps
iterencode = _JSON_ENCODER.iterencode
if isinstance(startedDateTime, datetime):
startedDateTime = startedDateTime.isoformat()
write(f"{separator} {{")
write(f'\n "startedDateTime": "{startedDateTime}",')
write(f'\n "time": {time},')
write(f'\n "request": {dumps(request.asdict())},')
write(f'\n "response": {dumps(response.asdict())},')
write(f'\n "timings": {dumps(timings.asdict())},')
write('\n "request": ')
for chunk in iterencode(request.asdict()):
write(chunk)
write(',\n "response": ')
for chunk in iterencode(response.asdict()):
write(chunk)
write(',\n "timings": ')
for chunk in iterencode(timings.asdict()):
write(chunk)
cache = cache or Cache()
write(f'\n "cache": {dumps(cache.asdict())}')
write(',\n "cache": ')
for chunk in iterencode(cache.asdict()):
write(chunk)
if serverIPAddress:
write(f',\n "serverIPAddress": {dumps(serverIPAddress)}')
write(',\n "serverIPAddress": ')
for chunk in iterencode(serverIPAddress):
write(chunk)
if connection:
write(f',\n "connection": {dumps(connection)}')
write(',\n "connection": ')
for chunk in iterencode(connection):
write(chunk)
if comment:
write(f',\n "comment": {dumps(comment)}')
write(',\n "comment": ')
for chunk in iterencode(comment):
write(chunk)
write("\n }")

def _write_preamble(self) -> None:
Expand Down