Independent Readers in ScriptInfo #194
Conversation
ScriptModule, for example, does not reset the Reader aquired via `ScriptInfo.getReader()`. While it is definitely an option to fix this issue by resetting it there, this way we can ensure that the behaviour of `ScriptInfo.getReader()` stays consistent. Also, this solution makes way to some day maybe run ScriptModules in parallel. Signed-off-by: Squareys <Squareys@googlemail.com>
Signed-off-by: Squareys <Squareys@googlemail.com>
There was a problem hiding this comment.
This number is pretty arbitrary. Any ideas on that? Use the probably also arbitrary (but alot bigger) PARAM_CHAR_MAX instead? :)
This code is based off of the code I wrote in scripting-java a while ago.
|
It would be great, if someone could quickly review this, since this would fix scijava/scripting-jython#6. |
Independent Readers in ScriptInfo
|
Thanks @Squareys. In retrospect, the design of the The |
2 participants
Hi @ctrueden !
here is the pullrequest promised in scijava/scripting-jython#6. My solution changes
ScriptInfoas follows:Instead of
ScriptInfo.getReader()returning the reader passed onto the constructor of ScriptInfo, the constructor now reads the entire contents of the Reader into a string, so thatScriptInfo.getReader()can return a newStringReader.Greetings,
Squareys