Always use UTF-8 when loading scripts from URL #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that scripts containing non-ASCII characters (such as
äöü) are not loaded correctly on Windows when they are loaded from within a jar file.See imagej/example-script-collection@fb97574 for some example scripts that currently fail (on Windows).
With this PR, the above scripts work as expected.
@ctrueden do you think it is safe to always use UTF-8 here, or are there cases of other URLs where we need to allow different encodings? In that case, we should make sure to use the correct encoding in all situations.