Skip to content

Conversation

@gab1one
Copy link
Contributor

@gab1one gab1one commented Sep 4, 2018

No longer throws a NullPointerException when a handle can not be created

No longer throws NullPointerException when a handle can not be
created.
@gab1one gab1one force-pushed the datahandle-service-nullpointer branch from 60b56ce to 6123ff1 Compare September 4, 2018 13:51
@gab1one gab1one changed the title DataHandleService: better handling of null arguments DataHandleService: better handling of failure states Sep 4, 2018
@ctrueden
Copy link
Member

ctrueden commented Sep 4, 2018

Please add a commit that documents the pre- and post-conditions of these methods, especially when null is given as the argument. This PR changes the assumptions, which is fine, but as long as we are thinking about nulls, let's be explicit about the intended behavior now.

@gab1one gab1one requested a review from ctrueden September 18, 2018 07:40
@ctrueden ctrueden merged commit b46eeb0 into master Oct 2, 2018
@gab1one gab1one deleted the datahandle-service-nullpointer branch October 15, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants