Skip to content

Conversation

@gselzer
Copy link
Member

@gselzer gselzer commented May 19, 2023

This PR allows scripts to be found in the base script directory.

@gselzer gselzer requested review from ctrueden and hinerm May 19, 2023 17:41
@gselzer gselzer self-assigned this May 19, 2023
@gselzer gselzer force-pushed the find-scripts-in-base-dir branch from 080fd76 to 23f0a46 Compare May 19, 2023 17:42
@gselzer gselzer force-pushed the find-scripts-in-base-dir branch from 23f0a46 to 8293f84 Compare May 19, 2023 17:43
@hinerm
Copy link
Member

hinerm commented May 19, 2023

This works, functionally, in principle. In practice, when I drop this in Fiji the discovered scripts aren't actually accessible via the menus because there is no "Scripts" root menu path:
image

What about just putting them in /plugins/Scripts anyway? since that's where they go on the file system?

@hinerm
Copy link
Member

hinerm commented May 19, 2023

In practice, when I drop this in Fiji the discovered scripts aren't actually accessible via the menus because there is no "Scripts" root menu path:

OK this was me being dumb and forgetting that everything, including scripts, need to have an underscore (_) in the file name to be placed into the GUI menus.

So yeah, this fix works. But I don't love that it creates a new menu entry called "Scripts" because.. there are tons of scripts that are NOT going into that directory (most of them)

In a local Fiji installation the scripts directory is in the plugins directory, so collecting them into the Plugins menu or submenu thereof seems reasonable?

@hinerm hinerm merged commit 2653899 into master May 23, 2023
@hinerm hinerm deleted the find-scripts-in-base-dir branch May 23, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants