[WIP] Introduce a new editable mode build-dir
#1170
Draft
+68
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
force-pushed
the
editable/build-dir
branch
from
7896f71 to
b53c732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this new mode is to keep all the artifacts in either the source-dir or the CMake build-dir. From there we reuse the
_editable_redirect.pyas having onlyknown_source_filesand we include the build-dir files in that mapping.In order to avoid conflicts with changes in #808, we should limit the scope here to python loadable sources and not cover
importlib.resource.filesright now. I will try to still gather those, but will filter those out of the_editablefile for now until we figure out how we should pass them.TODO:
Closes #1160