Skip to content

Conversation

henryiii
Copy link
Collaborator

Closes #128.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #135 (7bd8658) into main (362a5a1) will increase coverage by 0.10%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   90.53%   90.63%   +0.10%     
==========================================
  Files          43       43              
  Lines        1732     1773      +41     
==========================================
+ Hits         1568     1607      +39     
- Misses        164      166       +2     
Impacted Files Coverage Δ
src/scikit_build_core/settings/sources.py 88.84% <92.00%> (+0.22%) ⬆️
...cikit_build_core/settings/skbuild_read_settings.py 98.21% <100.00%> (+0.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit 91c09b5 into main Nov 23, 2022
@henryiii henryiii deleted the henryiii/feat/dym branch November 23, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better failure message for bad config

1 participant