Skip to content

fix: EXT_SUFFIX wrong before 3.8.7 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2022
Merged

fix: EXT_SUFFIX wrong before 3.8.7 #160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80c4a30
fix: EXT_SUFFIX wrong before 3.8.7
henryiii Dec 13, 2022
1fa8422
typing: better fix for too-wide output
henryiii Dec 13, 2022
a9f18d0
style: pre-commit fixes
pre-commit-ci[bot] Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/scikit_build_core/builder/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,14 @@ def configure(
# Workaround for bug in PyPy and packaging that is not handled in CMake
# According to PEP 3149, SOABI and EXT_SUFFIX are interchangeable (and
# the latter is much more likely to be correct as it is used elsewhere)
ext_suffix = sysconfig.get_config_var("EXT_SUFFIX")
assert ext_suffix
if sys.version_info < (3, 8, 7):
# See https://github.com/python/cpython/issues/84006
import distutils.sysconfig # pylint: disable=deprecated-module

ext_suffix = distutils.sysconfig.get_config_var("EXT_SUFFIX")
else:
ext_suffix = sysconfig.get_config_var("EXT_SUFFIX")
assert isinstance(ext_suffix, str)
cache_config["SKBUILD_SOABI"] = ext_suffix.rsplit(".", 1)[0].lstrip(".")

if cache_entries:
Expand Down