tests: reproducible #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
henryiii
commented
Nov 9, 2022
henryiii
commented
- tests: tarfile on older Pythons was different.
- tests: adding failing test for wheel
henryiii
force-pushed
the
henryiii/tests/hash
branch
from
0a0c2f8 to
e999695
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/tests/hash
branch
2 times, most recently
from
a451d0f to
833b9e3
Compare
24 tasks
henryiii
commented
Nov 9, 2022
| assert add.strip() == "3" | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Doesn't work yet") |
Collaborator
Author
There was a problem hiding this comment.
@agoose77 this didn't pass when I ran it locally, so I'm thinking it's not automatically handled?
Contributor
There was a problem hiding this comment.
Hmm, yes I dug deeper and there's only mention of SOURCE_DATE_EPOCH for the scripts portion of the wheel. It's odd - distlib seems like a mature project, but I don't get the impression that it's too concerned with implementing reproducibility.
Collaborator
There was a problem hiding this comment.
How about changing this to XFail? Isn't it expected to work as written later on?
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/tests/hash
branch
from
833b9e3 to
eadff9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.