Skip to content
This repository was archived by the owner on Jan 7, 2023. It is now read-only.

Conversation

@maxnoe
Copy link

@maxnoe maxnoe commented Jan 26, 2015

I added a call to root-config --cflags to check if root was build with c++11 features and if this is the case -std=c++11 is added to the extra-compile-args for librootnumpy.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f3166ea on MaxNoe:master into b400760 on rootpy:master.

@ndawe
Copy link
Member

ndawe commented Jan 26, 2015

This is already done in #165 but there are still bugs in ROOT 6 that are causing crashes.

@ndawe
Copy link
Member

ndawe commented Jan 26, 2015

We are waiting for ROOT devs to fix the bugs in ROOT 6 before merging #165.

@kratsg
Copy link
Collaborator

kratsg commented Jan 27, 2015

Should this be closed as duplicate issue? #165 certainly fixes it. In the mean time, they can edit their installation locally and reinstall.

@ndawe
Copy link
Member

ndawe commented Jan 27, 2015

Yes, let's close this.

@ndawe ndawe closed this Jan 27, 2015
@ndawe
Copy link
Member

ndawe commented Jan 27, 2015

@maxnoe sorry for closing this! We implemented the same thing a few weeks ago but then hit a bunch of problems in ROOT 6 that need to be fixed before root_numpy can be used there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants