This repository was archived by the owner on Jan 9, 2023. It is now read-only.
setup.py: update of URL and authors/maintainers #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Any comments @chrisburr ? |
Member
|
I wasn't aware of the maintainer field but yes this is a nicer. @ibab As this package is mostly your work, do you have any objections to it being BSD-3 instead of MIT to be more consistent with other scikit-hep packages? |
Member
Author
|
Shall we just create an issue for the question about licensing and accept this PR? Seems the way to go :-). |
Member
|
Yes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisburr, would you consider updating the info in the setup.py file as follows? Seems nicer to me for a community package.
I fixed the URL in any case.
There is also the issue of the license. I would push for a BSD-3 license as we have for all Scikit-HEP projects, where possible. Could you give that a thought? This would require some additions as a 1-line header to the various files, see the other projects ...
Let me know :-). Thanks.