Skip to content

Conversation

@pfackeldey
Copy link
Collaborator

@pfackeldey pfackeldey commented Aug 8, 2025

This PR fixes the handling of lib for non-NumPy and non-TypeTracer backends with awkward array.

fyi @MoAly98

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.58%. Comparing base (bd7c9b4) to head (af89937).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          95       95           
  Lines       12057    12058    +1     
=======================================
+ Hits        10560    10561    +1     
  Misses       1497     1497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pfackeldey pfackeldey requested a review from Saransh-cpp August 8, 2025 17:34
@pfackeldey
Copy link
Collaborator Author

(btw, I think we should deprecate python 3.8 by now...)

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pfackeldey!

@Saransh-cpp
Copy link
Member

(btw, I think we should deprecate python 3.8 by now...)

We have 3.8 in CI mostly because of #531. I haven't had the time to look at it yet, but I guess we can keep running 3.8 in the CI and think about it once it can no longer be accessed in GH Actions.

@pfackeldey
Copy link
Collaborator Author

@Saransh-cpp this is independent of python 3.8. In case you're happy with it, this could be merged from my side.

@Saransh-cpp
Copy link
Member

Thanks, @pfackeldey! Looks good to me.

@Saransh-cpp Saransh-cpp merged commit bc3576d into main Aug 13, 2025
20 checks passed
@Saransh-cpp Saransh-cpp deleted the pfackeldey/fix_lib_inference branch August 13, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants