Skip to content

Conversation

@Badr-MOUFAD
Copy link
Collaborator

@Badr-MOUFAD Badr-MOUFAD commented Nov 2, 2023

Context of the PR

Setting up a Python project with pyproject.toml file has become the standard.
This PR makes the necessary modifications to adopt this standard.

Closes #160

Contributions of the PR

  • move setups and metadata from setup.py to pyproject.toml
  • move documentation and test requirements to pyproject.toml
  • updates CI workflows and documentation to account for the modifications

Checks before merging PR

  • [ ] added documentation for any new feature
  • [ ] added unittests
  • [ ] edited the what's new(if applicable)

@Badr-MOUFAD Badr-MOUFAD linked an issue Nov 2, 2023 that may be closed by this pull request
@Badr-MOUFAD Badr-MOUFAD requested a review from mathurinm November 2, 2023 12:40
@mathurinm mathurinm merged commit 035ad65 into scikit-learn-contrib:main Nov 7, 2023
@Badr-MOUFAD Badr-MOUFAD deleted the switch-pyproject branch November 7, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MNT - adopt pyproject.toml to setup skglm MAINT - move github_link.py to sphinxext folder

2 participants