Skip to content

Conversation

@Badr-MOUFAD
Copy link
Collaborator

Context of the PR

The links used to get to the stable and dev documentation are relative, hence they break when used in a location other than home.

Contributions of the PR

  • Use absolute links

Checks before merging PR

  • [ ] added documentation for any new feature
  • [ ] added unittests
  • [ ] edited the what's new(if applicable)

@mathurinm
Copy link
Collaborator

Thanks @Badr-MOUFAD , I guess it's hard to test without the stable version ? I get this https://output.circle-artifacts.com/output/job/28660a6b-46f2-4638-b9f2-dff74aaac6c4/artifacts/0/dev/generated/stable/index.html when clicking on "stable"

@Badr-MOUFAD
Copy link
Collaborator Author

Since the stable documentation is "stable", we better use the link of the deployed documentation?

@mathurinm
Copy link
Collaborator

yes I think we can ; with the current version I still get redirected to the same address and thus get an error

@mathurinm mathurinm merged commit efde9b8 into scikit-learn-contrib:main Jan 10, 2024
@mathurinm
Copy link
Collaborator

Thanks a lot @Badr-MOUFAD

floriankozikowski pushed a commit to PascalCarrivain/skglm that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants