Skip to content

Conversation

@YanisLalou
Copy link

Reference Issues/PRs

Fixes #28430

The bug was observed in 2 classes with the same implementation but different names. The first one was named class_1, and the other Class_1.
It was observed that in the _metadata_requests functions, sorting was performed between dictionary keys. Considering that the default sorted() function follows ASCII order, where uppercase letters precede lowercase letters and underscores precede alphanumeric characters.
It appears that the sorting order is affecting the final results of ._get_metadata_request().

What does this implement/fix? Explain your changes.

Removed the sorting of the dictionary defaults in _metadata_requests.py.
By sorting this dictionary, the __metadata_request__* attributes were not the same as the child class but the same as the last class in the sorted dictionary.

@github-actions
Copy link

github-actions bot commented Feb 15, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 58fc293. Link to the linter CI: here

@adrinjalali
Copy link
Member

Thanks for the PR. Could you please provide a minimal reproducible?

@adrinjalali
Copy link
Member

Pretty sure removing sorted is not the solution. Let me see what I can come up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name of a class impacts the value of its __metadata_request__* variables

2 participants