update setup.py w.r.t. SCIP 10 #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path to config.h in SCIP 10 is given by lib/shared/include/scip/config.h now. Before this was avoided by using NO_CONFIG_HEADER.
Joao-Dionisio
approved these changes
Nov 10, 2025
Member
Joao-Dionisio
left a comment
Joao-Dionisio
left a comment
There was a problem hiding this comment.
Looks good, I'm just curious about the f-strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path to config.h in SCIP 10 is given by
lib/shared/include/scip/config.hnow.The file
config.his generated depending on the build flags of make and is placed next to the.ofiles.But then there is was no connection from
libsciptoconfig.h.In SCIP 10 this is now resolved by using the generic path mentioned above.
The change now also gets rid of
NO_CONFIG_HEADERwhich was a work-around.