Skip to content

Conversation

@jokasimr
Copy link
Contributor

Fixes #70

@jokasimr jokasimr requested a review from jl-wynen June 26, 2024 07:19
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this works with #71 !

@jokasimr
Copy link
Contributor Author

Please make sure this works with #71 !

Do you mean make sure to avoid merge conflicts? Or some other aspect?

@jl-wynen
Copy link
Member

No, to make sure that things don't break at runtime. Basically, don't merge this PR until #71 is merged.


assert "sector" not in mantle.bins.coords
assert "tof" in mantle.bins.coords
assert "wavelength" in mantle.bins.coords
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will now cause merge conflicts with #71

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for #71 to be merged before rebasing this

@jokasimr jokasimr force-pushed the not-load-wavelength branch from 72425f4 to 297dd31 Compare July 1, 2024 07:40
@jokasimr jokasimr merged commit 6cbbd65 into main Jul 1, 2024
@jokasimr jokasimr deleted the not-load-wavelength branch July 1, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not load wavelength from GEANT4 CSV

4 participants