Copier udpate & dependency update #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokasimr
reviewed
Aug 15, 2024
Contributor
jokasimr
left a comment
jokasimr
left a comment
There was a problem hiding this comment.
Do we need to add pooch as a test dependency in conda/meta.yaml? In essreflectometry the release build failed because the conda release action didn't have access to pooch. See scipp/essreflectometry#69 (review)
Member
Author
I did forget to update conda/meta.yml...! Thank you : D |
jokasimr
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
essreducenow hosts theJsonGroupsobeamlimeneeds it in the dependency.