Add provider to tof workflow to compute toa #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+500
to
+501
| if inputs["pulse_index"] is not None: | ||
| parts["data"] = parts["data"] + inputs["pulse_index"] * inputs["pulse_period"] |
Member
There was a problem hiding this comment.
When would it be None? What is the meaning of that case? No pulse-skipping?
Member
Author
There was a problem hiding this comment.
Yes, when there is no pulse-skipping, the pulse_index is None. It is this way to avoid allocating a large array of zeros (size Nevents) if it is not needed.
I added a comment to clarify.
|
|
||
|
|
||
| class ToaDetector(sl.Scope[RunType, sc.DataArray], sc.DataArray): | ||
| """Detector data with time-of-arrival coordinate.""" |
Member
There was a problem hiding this comment.
Extend description to clarify difference with event_time_offset?
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
SimonHeybrock
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time-of-arrival is defined as
event_time_offset + pulse_index * pulse_period.It is useful if one wishes to histogram event data which uses pulse skipping, as it unwraps the data over the full frame period (instead of the pulse period that the event_time_offset gives).
We add a provider which computes the detector data with a
toacoord.It is not computed as part of the normal tof workflow, only computed upon request.
Some code was refactored to avoid large duplications.