Skip to content

fix: change coordinate system consistently #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

fix: change coordinate system consistently #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec925c
fix: change coordinate system consistently
jokasimr Nov 11, 2025
8b33362
fix
jokasimr Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ess/reduce/time_of_flight/fakes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def __init__(
else tof_pkg.Clockwise,
open=ch.slit_begin,
close=ch.slit_end,
phase=abs(ch.phase),
phase=ch.phase if ch.frequency.value > 0.0 else -ch.phase,
Copy link
Member

@nvaytet nvaytet Nov 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the order of operations in tof, does this go away?
(first add phase, and then mirror)

Copy link
Contributor Author

@jokasimr jokasimr Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I could not make it go away by changing anything in tof.
I lean towards the implementation in tof being correct.

distance=sc.norm(ch.axle_position - source_position),
name=name,
Copy link
Member

@nvaytet nvaytet Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add properly maintained methods in tof to construct chopper from DiskChopper and NeXus.
I suspect this code exists in multiple places (packages, notebooks etc...)

See scipp/tof#6.

Copy link
Contributor Author

@jokasimr jokasimr Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds like a good idea. Do you want to see that in this PR?

Copy link
Member

@nvaytet nvaytet Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to see that in this PR?

No, I will do that separately.

)
Expand Down
2 changes: 1 addition & 1 deletion src/ess/reduce/time_of_flight/lut.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ def simulate_chopper_cascade_using_tof(
else tof.Clockwise,
open=ch.slit_begin,
close=ch.slit_end,
phase=abs(ch.phase),
phase=ch.phase if ch.frequency.value > 0.0 else -ch.phase,
distance=sc.norm(
ch.axle_position - source_position.to(unit=ch.axle_position.unit)
),
Expand Down
Loading