Fix nightly builds #125
Merged
Fix nightly builds #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Mar 3, 2025
pyproject.toml
Outdated
| 'ignore:\n.*Sentinel is not a public part of the traitlets API.*:DeprecationWarning', | ||
| "ignore:.*metadata to be logged in the data array, it is necessary to install the orsopy package.:UserWarning", | ||
| "ignore:.*A transformation needs a vector attribute. Falling back to returning underlying value.:UserWarning", | ||
| "ignore:Invalid transformation.*'vector':UserWarning", |
Member
There was a problem hiding this comment.
Is this only for Amor files? If so, can you disable the warning only for those tests?
Member
Author
There was a problem hiding this comment.
Yes, good point. Can you remind me how we do that?
Member
There was a problem hiding this comment.
This is in the integration testing repo:
# The files used in the AMOR ESTIA reduction workflow have some scippneutron warnings
pytestmark = pytest.mark.filterwarnings(
"ignore:.*Invalid transformation, missing attribute 'vector':UserWarning",
)You can put this into a *_test.py file or if there are multiple, into the Amor conftest.py file.
jl-wynen
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress new warnings that have appeard from
scippnexusupdate.