fix: show nonnan aggregates #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
reviewed
May 7, 2025
| min_ = coord.min().value | ||
| max_ = coord.max().value | ||
| min_ = coord.nanmin().value | ||
| max_ = coord.nanmax().value |
Member
There was a problem hiding this comment.
Just for curiosity when do events end up with a nan coord?
Contributor
Author
There was a problem hiding this comment.
That typically happens when we are unable to estimate the wavelength of the neutron.
We are unable to estimate the wavelength of the neutron if it arrived at a time, at a place in the detector where
- we don't expect to see any events, or
- the wavelength of the neutron is ambiguous.
Contributor
Author
There was a problem hiding this comment.
As an example, here is where the wavelength is computed in the Amor workflow: https://github.com/scipp/essreflectometry/blob/main/src/ess/amor/conversions.py#L122-L130
If the arrival time is outside of the expected range it's assigned nan.
MridulS
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the min-max range of wavelength and incident angle in the orso files could be
nanif such values occurred in the data. That happened because we don't explicitly add a mask for events withnanin the coordinates, we don't need an explicit mask to exclude such events in the reduction because they are discarded in the binning anyway.