Skip to content

Conversation

@jl-wynen
Copy link
Member

@jl-wynen jl-wynen commented Jun 4, 2025

This is basically the same as what I did with the DREAM user guide. I split the ESTIA guide into a basic notebook that only shows how to reduce some data and an advanced guide that expands on the basic one.

I only did this with the ESTIA docs as the others aren't the main focus of this package.

I removed the sections dealing with different samples because they were identical to the Ni/Ti sample except for different input files. This didn't teach the reader anything new.

Copy link
Contributor

@jokasimr jokasimr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

"metadata": {},
"source": [
"The Estia reduction workflow is created and we set parameters such as region of interest, wavelengthbins, and q-bins."
"We then need to set the missing parameters which are specific to each experiment (the keys are types defined in [ess.reflectometry.types](../../generated/modules/ess.reflectometry.types.rst))."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useful to mention that the parameters defines the region of interest etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments for the individual parameter groups.

"wf = EstiaMcStasWorkflow()\n",
"wf.insert(load_mcstas_events)\n",
"# Specify input data files:\n",
"# (The choice of the 2nd 'Ni/Ti-multilayer' file is arbitrary.)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 4th?

@jokasimr
Copy link
Contributor

The thumbnails don't seem to exist in the preview: https://remote-unzip.deno.dev/scipp/essreflectometry/artifacts/3259230727/user-guide/estia/index.html but maybe it's not like that in the published version.

"source": [
"param_table = pd.DataFrame({\n",
" Filename[SampleRun]: estia_mcstas_example('Ni/Ti-multilayer')\n",
"}).rename_axis(index='run')\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about renaming this index to sample rotation angle or something like that? Essentially that is the dimension the series runs over.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed it to sample_rotation to match the coord name.

@jl-wynen
Copy link
Member Author

The thumbnails don't seem to exist in the preview: https://remote-unzip.deno.dev/scipp/essreflectometry/artifacts/3259230727/user-guide/estia/index.html but maybe it's not like that in the published version.

Apparently I forgot to commit them.

@jl-wynen jl-wynen enabled auto-merge June 10, 2025 13:47
@jl-wynen jl-wynen merged commit 180c20f into main Jun 10, 2025
4 checks passed
@jl-wynen jl-wynen deleted the docs-tiles branch June 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants