fix: remove progress when reduction is finished #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Aug 28, 2025
| self.progress_log.children = (progress,) | ||
|
|
||
| def hide_progress(self): | ||
| self.progress_log.children = () |
Member
There was a problem hiding this comment.
Isn't this going to move the UI elements around? Can the progress bar be placed somewhere where adding / removing it doesn't change the layout?
Contributor
Author
There was a problem hiding this comment.
Good point. I moved the progress bar next to the reduction buttons. That's going to make it not move things around, and it is probably also better UX because the progress bar shows up where you are looking when you press "Plot" or "Reduce".
jl-wynen
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the progress bar stayed until a new run was issued.
This was confusing because even if the bar is full it looks a bit like the reduction is not finished.
It is extra confusing in cases when one or more of the reductions failed, because then the progress bar does not fill up completely.
This PR makes the progress bar go away when the reduction is finished, clearly demonstrating that the work is done.