feat: scale critical edge to 1 #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokasimr
force-pushed
the
scale-critical-edge
branch
from
2740bd6 to
0732434
Compare
jokasimr
force-pushed
the
scale-critical-edge
branch
from
0732434 to
6b85d5c
Compare
| coords={'Q': sc.linspace('Q', *critical_edge_interval, N + 1)}, | ||
| ) | ||
| curves, factors = scale_reflectivity_curves_to_overlap([edge, *curves]) | ||
| return curves[1:], factors[1:] |
Member
There was a problem hiding this comment.
Would it make sense to set the scale factor as a coord in each curve? Returning a tuple of lists seems a bit error prone.
Contributor
Author
There was a problem hiding this comment.
Right now I prefer the tuple of lists because it's simple and obvious. For example, setting it as a coord requires the user to know the name of the coord to extract the return value. I don't directly see why it would be more error prone, did you have a particular situation in mind?
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
Co-authored-by: Simon Heybrock <12912489+SimonHeybrock@users.noreply.github.com>
SimonHeybrock
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
Fixes #96
Draft because needs tests and docs