Support ISIS histogram files #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Jun 10, 2025
| # Loading many small files with Mantid is, for some reason, very slow when using | ||
| # the default number of threads in the Dask threaded scheduler (1 thread worked | ||
| # best, 2 is a bit slower but still fast). We can either limit that thread count, | ||
| # or add a lock here, which is more specific. |
Member
There was a problem hiding this comment.
Interesting. This might also help with other loaders. I saw some slowdown in BIFROST when using a threaded scheduler.
Member
Author
There was a problem hiding this comment.
You think this is due to HDF5 and not just Mantid?
Member
There was a problem hiding this comment.
Possibly. But I don't know. We should investigate
src/ess/isissans/mantidio.py
Outdated
| ) | ||
| except TypeError: | ||
| # Not loaded using LoadEventNexus, so LoadMonitor option is not available. | ||
| loaded = _mantid_simpleapi.Load(Filename=str(filename), StoreInADS=False) |
Member
There was a problem hiding this comment.
Why do you call Load again after the lock?
Member
Author
There was a problem hiding this comment.
Oops, should have been inside the lock. See update,
Co-authored-by: Jan-Lukas Wynen <j-l.wynen@hotmail.de>
Co-authored-by: Jan-Lukas Wynen <j-l.wynen@hotmail.de>
Co-authored-by: Jan-Lukas Wynen <j-l.wynen@hotmail.de>
jl-wynen
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the title says. Needed for processing ZOOM polarized data.
So far I do not have permission to share the files, so there is no added test.