Skip to content

Fix camera position zoom after pan #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

Fix camera position zoom after pan #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2b009
fix zoom limits when zooming after having panned
nvaytet Nov 11, 2025
a4d122e
fix set_xylim after pan
nvaytet Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 11 additions & 22 deletions src/matplotgl/axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ def __init__(self, *, ax: MplAxes, figure=None) -> None:
self.collections = []
self.images = []

# Make background to enable box zoom
# Make background to enable box zoom.
# Use a size based on limits of the float32 range.
self._background_geometry = p3.PlaneGeometry(
width=2, height=2, widthSegments=1, heightSegments=1
width=6e38, height=6e38, widthSegments=1, heightSegments=1
)
self._background_material = p3.MeshBasicMaterial(color=self.background_color)
self._background_mesh = p3.Mesh(
Expand Down Expand Up @@ -329,18 +330,6 @@ def autoscale(self):
else (1.0 if self.get_yscale() == "linear" else 10.0)
)

self._background_mesh.geometry = p3.PlaneGeometry(
width=2 * (self._xmax - self._xmin),
height=2 * (self._ymax - self._ymin),
widthSegments=1,
heightSegments=1,
)

self._background_mesh.position = [
0.5 * (self._xmin + self._xmax),
0.5 * (self._ymin + self._ymax),
self._background_mesh.position[-1],
]
self.reset()

def add_artist(self, artist):
Expand Down Expand Up @@ -503,8 +492,8 @@ def set_xlim(self, left, right=None):
left = left[0]
self._xmin = left
self._xmax = right
self.camera.left = left
self.camera.right = right
self.camera.left = left - self.camera.position[0]
self.camera.right = right - self.camera.position[0]
self._make_xticks()

def get_ylim(self):
Expand All @@ -519,8 +508,8 @@ def set_ylim(self, bottom, top=None):
bottom = bottom[0]
self._ymin = bottom
self._ymax = top
self.camera.bottom = bottom
self.camera.top = top
self.camera.bottom = bottom - self.camera.position[1]
self.camera.top = top - self.camera.position[1]
self._make_yticks()

def get_xticks(self):
Expand Down Expand Up @@ -577,10 +566,10 @@ def zoom(self, box):
"ymax": box[3],
}
with self.camera.hold_trait_notifications():
self.camera.left = self._zoom_limits["xmin"]
self.camera.right = self._zoom_limits["xmax"]
self.camera.bottom = self._zoom_limits["ymin"]
self.camera.top = self._zoom_limits["ymax"]
self.camera.left = self._zoom_limits["xmin"] - self.camera.position[0]
self.camera.right = self._zoom_limits["xmax"] - self.camera.position[0]
self.camera.bottom = self._zoom_limits["ymin"] - self.camera.position[1]
self.camera.top = self._zoom_limits["ymax"] - self.camera.position[1]
if self.get_xscale() == "log":
xlim = (
10.0 ** self._zoom_limits["xmin"],
Expand Down
Loading