Upgrade and corrections #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added inner_bounding and changed the code to use Ordered Dictionnaries to prevent random ordering of keys and values, making the function more stable and prevent some potential issues.
Member
|
no problem, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for creating this new pull so soon after the first one just got accepted, but I had to make some change and improvement to the code to improve usage and flexibility.
What changed:
Added inner_bounding: so any optimization could be used as the values will be capped by the wrapper.
Dict-> OrderedDict: I wanted to make sure that dictionnary arguments were processed in the proper order so if you wanted to create the x0 vector/array manually you would not give the wrong value to a random kwarg.
and maybe some other minor correction and change of names