Skip to content

move LGMRES demo over from scipy #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2022
Merged

move LGMRES demo over from scipy #50

merged 2 commits into from
Jul 24, 2022

Conversation

@j-bowhay
Copy link
Member

@j-bowhay j-bowhay commented Jul 23, 2022

@j-bowhay j-bowhay mentioned this pull request Jul 23, 2022
Merged
rgommers
rgommers requested changes Jul 24, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @j-bowhay. Something is wrong here though - the output looks small, but the .ipynb is 4 MB in size. Can you strip the outputs stored in there?

@j-bowhay
Copy link
Member Author

j-bowhay commented Jul 24, 2022

@rgommers hadn't spotted that! Have removed the output which has made the file size much more reasonable

rgommers
rgommers approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@rgommers rgommers merged commit 75ef976 into scipy:main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j-bowhay @rgommers