🐛stats.unitary_group.rvs: fix return dtype
#993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the return dtype for stats.unitary_group.rvs to correctly return np.complex128 instead of the default np.float64. The fix is implemented by adding generic type parameters to the internal group random variable mixin classes and specializing unitary_group to use np.complex128.
- Added comprehensive regression tests for
rvsreturn dtypes across all multivariate distributions - Introduced
_ScalarT_cocovariant type variable to parameterize the scalar dtype in group RV mixins - Specialized
unitary_group_genandunitary_group_frozento usenp.complex128
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/stats/test_multivariate.pyi | New test file with dtype assertions for all multivariate distribution rvs methods |
| scipy-stubs/stats/_multivariate.pyi | Added generic type parameters to group RV mixins and specialized unitary_group to return complex128 arrays |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #987
This also adds a couple of hand-verified regression tests for the other multivariate distribution
rvsreturn dtypes.