Skip to content

Conversation

@Nativu5
Copy link
Collaborator

@Nativu5 Nativu5 commented Jul 8, 2025

No description provided.

@Nativu5 Nativu5 requested a review from Copilot July 8, 2025 10:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a Ruff-based CI workflow and updates project configuration and code style to comply with Ruff’s rules.

  • Introduces a GitHub Actions workflow (.github/workflows/ruff.yml) to run Ruff on push and PRs
  • Moves and updates [project.urls] in the root pyproject.toml and configures Ruff (including an exclude setting)
  • Adjusts the client’s pyproject.toml and applies Ruff’s select rules, then auto-formats code across the netpulse-client package

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Moved [project.urls] block below [project.scripts] and added tool.ruff.exclude
netpulse-client/pyproject.toml Simplified [tool.ruff] config to a unified select list
.github/workflows/ruff.yml New workflow to install, format, fix, and check with Ruff
netpulse-client/netpulse_client/models.py Reordered imports, punctuation tweaks, and minor class additions
netpulse-client/netpulse_client/client.py Reordered imports, added type hints, and removed debug prints
netpulse-client/examples/sdk_test.py Adjusted import order in example script
Comments suppressed due to low confidence (3)

netpulse-client/netpulse_client/client.py:60

  • The api_key constructor parameter is never used in requests. To authenticate calls, add an Authorization header (for example, "Authorization": f"Bearer {api_key}") when building the client session.
            headers={"Content-Type": "application/json", "User-Agent": "NetPulse-Client/0.1.0"},

netpulse-client/netpulse_client/models.py:61

  • [nitpick] The class name PyeapiConnectionArg is inconsistent with the other *ConnectionArgs classes (e.g., NetmikoConnectionArgs, NapalmConnectionArgs). Consider renaming it to PyeapiConnectionArgs.
class PyeapiConnectionArg(ConnectionArgs):

pyproject.toml:96

  • The exclude setting in the root tool.ruff config currently skips the entire netpulse-client folder, so none of the client code will be linted by CI. Consider removing or narrowing this exclude to ensure your new client code is checked.
exclude = ["netpulse-client/*"]

@Nativu5 Nativu5 merged commit 2ce9f3f into scitix:master Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant