add bids download to master #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
closes #78 |
api/core.py
Outdated
Contributor
Author
|
will work on this pull request to add a generic way of filtering downloads by type or tag. |
Contributor
Author
|
Still need to address Gunnar's comment, apart from that the PR is ready to be reviewed. |
rentzso
force-pushed
the
bids_download_to_master
branch
2 times, most recently
from
5175b71 to
93221eb
Compare
Contributor
Author
|
addressed @gsfr comment |
api/core.py
Outdated
Member
There was a problem hiding this comment.
Wouldn't this long comment be better placed into the docstring of the download method?
Member
|
LGTM. The branch is quite a bit behind master, so please rebase before the merge to make sure we don't get any unintended side-effects. |
rentzso
force-pushed
the
bids_download_to_master
branch
from
8eb18c6 to
d62dff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of bids downloads to the master branch from aloha.
Minimal adaptation was done for standard downloads, but they essentially work as before.