Skip to content

Conversation

@ryansanford
Copy link
Contributor

…connections when API is hosted by API.

Issue #123

Add connect=False to pymongo.MongoClient() for multithreaded api service hosts such as uwsgi.

@rentzso @gsfr @kofalt

@kofalt
Copy link
Contributor

kofalt commented Jan 12, 2016

Mind documenting that change?
I get allergic quickly to opaque stuff like database connection settings, eg j=True.

Manually cross-referencing flags with database docs can help, but it'd be good to capture the intent as well for the next time we need to fiddle with the connection settings.

api/config.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ending the last line of such lists with a comma (,) allows for later additions to be one-line changes, unlike it was the case here.

@gsfr
Copy link
Member

gsfr commented Jan 12, 2016

I agree. End-of-line comments on at least j and connect would be great.

Clarify the intent of both 'j' and 'connect' options of pymongo.MongoClient().

closes #123
@ryansanford
Copy link
Contributor Author

@kofalt @gsfr
Requested changes have been integrated. Any other comments before merging?

@kofalt
Copy link
Contributor

kofalt commented Jan 13, 2016

LGTM

kofalt added a commit that referenced this pull request Jan 13, 2016
Resolve "No replica set members found yet" errors when using mongodb …
@kofalt kofalt merged commit 43688cb into master Jan 13, 2016
@kofalt kofalt deleted the issue_123 branch January 13, 2016 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants