Multiple files upload #135
Conversation
There was a problem hiding this comment.
It looks like this function is called several times without error handling.
If mongo throws an exception halfway through, will the result be a partial update? How bad is that?
There was a problem hiding this comment.
It's simply bad.
We would need a general "transaction" for multiple mongo operations as the reaper endpoint also applies multiple updates serially.
WIredTiger, a new mongo storage engine (default in 3.2) seems to provide a transaction system, http://source.wiredtiger.com/2.4.1/transactions.html
However I think that this issue is not in the scope of this PR, but we should definitely address it sooner than later. We should explore if WiredTiger is the way to go or if a home baked system would be better in term of flexibility/optimization vs development/maintenance time.
There was a problem hiding this comment.
Fair. Let's leave it for now.
|
LGTM pending a small question! |
This change enables a new route api/engine to handle uploads of multiple files with metadata.