Skip to content

Conversation

@nagem
Copy link
Contributor

@nagem nagem commented Feb 6, 2018

If acquisition timestamp and/or subject code are provided in the request payload metadata, use this information to be more specific in the query to find an existing container.

This fixes an issue where files with the same acquisition name but different timestamps ended up in the same container when they should be separate containers.

This also fixes an issue if two sessions with the same label but different subject codes are uploaded.

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@nagem
Copy link
Contributor Author

nagem commented Feb 6, 2018

Writing tests for situations noted above, look for those soon.

@codecov-io
Copy link

codecov-io commented Feb 6, 2018

Codecov Report

Merging #1066 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   91.18%   91.19%   +0.01%     
==========================================
  Files          50       50              
  Lines        6920     6931      +11     
==========================================
+ Hits         6310     6321      +11     
  Misses        610      610

@nagem nagem requested a review from kofalt February 6, 2018 20:22
@nagem nagem merged commit 4fb0b11 into master Feb 6, 2018
@nagem nagem deleted the match-timestamp branch February 6, 2018 22:18
ryansanford pushed a commit that referenced this pull request Feb 7, 2018
On packfile upload, use acquisition timestamp and subject code to find containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants