Skip to content

Conversation

@nagem
Copy link
Contributor

@nagem nagem commented Feb 6, 2018

If a job fails and is respawned, an analysis will attempt to update the job id to the most recently spawned job. If that update is required, old code would also update the analysis's input files to match the new job's inputs. Code prevents a change in inputs from one job attempt to the next, so this is unnecessary. It was causing issues in situations where inputs did not exist for a job, so it easier to just remove it.

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@codecov-io
Copy link

codecov-io commented Feb 6, 2018

Codecov Report

Merging #1067 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.02%     
==========================================
  Files          50       50              
  Lines        6931     6922       -9     
==========================================
- Hits         6321     6312       -9     
  Misses        610      610

@nagem nagem force-pushed the analysis-job-update branch from f399e2f to 3d39f43 Compare February 7, 2018 13:10
@nagem nagem merged commit 1dab2a1 into master Feb 7, 2018
@nagem nagem deleted the analysis-job-update branch February 7, 2018 13:14
ryansanford pushed a commit that referenced this pull request Feb 7, 2018
Remove unnecessary analysis input file update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants