Skip to content

Conversation

ryansanford
Copy link
Contributor

This variable was a temporary measure from #190 and never fully removed until now.

This variable was a temporary measure from #190 and never fully removed until now.
@ryansanford
Copy link
Contributor Author

@nagem and @gsfr -- can you test in your respective environments please including bootstrap process? Thanks.

@nagem
Copy link
Contributor

nagem commented May 18, 2016

LGTM, my only question is the differences between sample.config and the DEFAULT_CONFIG in config.py. I'm curious why RUNTIME configs only exist in sample.config and if they are required to remain there or if setting SCITRAN_SITE_API_URL is enough. This might be more of a legacy question for @gsfr.

@ryansanford
Copy link
Contributor Author

@nagem 6056ddf adds a comment regarding the RUNTIME vars. Essentially, they are only consumed by bin/run.sh for it to setup a standalone local instance hosted by paster, and not meant to be consumed by the API.

Let me know if that doesn't answer your question.

@gsfr
Copy link
Member

gsfr commented May 18, 2016

👍 Tested.

@ryansanford ryansanford merged commit 2a53361 into master May 18, 2016
@ryansanford ryansanford deleted the env-var-cleanup branch May 18, 2016 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants