Skip to content

Conversation

@kofalt
Copy link
Contributor

@kofalt kofalt commented Oct 4, 2017

The search size param would never succeed if set, because URL params are strings.

@kofalt kofalt added the Bug label Oct 4, 2017
@nagem
Copy link
Contributor

nagem commented Oct 4, 2017

LGTM

@codecov-io
Copy link

Codecov Report

Merging #947 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #947      +/-   ##
=========================================
- Coverage   90.14%   90.1%   -0.05%     
=========================================
  Files          48      48              
  Lines        6462    6465       +3     
=========================================
  Hits         5825    5825              
- Misses        637     640       +3
Flag Coverage Δ
#python 90.1% <0%> (-0.05%) ⬇️
Impacted Files Coverage Δ
api/handlers/dataexplorerhandler.py 83.66% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9ade2...09da875. Read the comment docs.

@kofalt kofalt merged commit 20a508d into master Oct 4, 2017
@kofalt kofalt deleted the fix-search-limit branch October 4, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants