Correct match_ids in containerhandler.get_jobs #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 90% 90.04% +0.04%
==========================================
Files 49 49
Lines 6640 6640
==========================================
+ Hits 5976 5979 +3
+ Misses 664 661 -3 |
Contributor
|
Changes LGTM. Please add a test to ensure utility and analysis jobs are properly returned via this endpoint. The code is covered, probably just need to modify an existing test to ensure utility and analysis jobs are returned. |
Contributor
kofalt
force-pushed
the
unique-checks-are-hard
branch
from
9287e15 to
629c928
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #972
Yeah, really dumb error here. Late night bug fixes 🛋️ 🥃