Skip to content

Conversation

@tito
Copy link
Contributor

@tito tito commented Jan 15, 2025

This pull request includes several changes to the scope3ai project, focusing on refactoring and simplifying the codebase by removing the Model class and updating various functions and imports accordingly. The most important changes include updating the ImpactRow instantiation, modifying the gpu and node functions in the client, and cleaning up imports across multiple files.

Refactoring and Simplifying Codebase:

  • Updating ImpactRow Instantiation:

    • model -> model_id
    • model_used -> model_used_id
    • fix input/output images fields
  • Modifying gpu and node Functions:

    • Changed the return type of the gpu function from GPU to GPUResponse and updated the node function to accept string parameters instead of enums in scope3ai/api/client.py.
  • Updating Documentation:

    • Updated the README.md to reflect changes in the command to generate typesgen.py.

These changes collectively simplify the codebase and improve maintainability by removing unnecessary complexity and ensuring consistency across various modules.

@tito tito force-pushed the mathieu/update-api branch from dae7e07 to 4a35f4c Compare January 15, 2025 23:29
@coveralls
Copy link
Collaborator

coveralls commented Jan 16, 2025

Pull Request Test Coverage Report for Build 12799820886

Details

  • 196 of 202 (97.03%) changed or added relevant lines in 21 files are covered.
  • 33 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+15.0%) to 95.594%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scope3ai/tracers/huggingface/image_to_image.py 11 12 91.67%
scope3ai/api/client.py 5 10 50.0%
Files with Coverage Reduction New Missed Lines %
scope3ai/tracers/huggingface/chat.py 1 98.84%
scope3ai/tracers/huggingface/speech_to_text.py 1 98.04%
scope3ai/tracers/huggingface/translation.py 2 96.36%
scope3ai/tracers/anthropic/chat.py 4 97.08%
scope3ai/tracers/openai/chat.py 4 95.0%
scope3ai/worker.py 5 89.69%
scope3ai/lib.py 16 90.23%
Totals Coverage Status
Change from base Build 12553763769: 15.0%
Covered Lines: 2061
Relevant Lines: 2156

💛 - Coveralls

@tito tito marked this pull request as ready for review January 16, 2025 00:51
@tito tito merged commit 39a8a42 into main Jan 16, 2025
20 checks passed
@tito tito deleted the mathieu/update-api branch January 16, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants