Skip to content

Conversation

dearlordylord
Copy link
Contributor

@dearlordylord dearlordylord commented Mar 17, 2025

MSP dictionary extension

UPD

  • added clearer distinction between PROVIDERs and CLIENTs
  • send a PROVIDER by-default if possible to clearly determine

upd: we don't use the python lib anywhere right now

@dearlordylord dearlordylord force-pushed the feat/managed-servide-provider-dictionary branch from d4eaa09 to 421ae37 Compare March 17, 2025 19:30
@dearlordylord dearlordylord requested a review from tito March 17, 2025 19:30
@dearlordylord dearlordylord force-pushed the feat/managed-servide-provider-dictionary branch from 421ae37 to b5bbc92 Compare March 17, 2025 19:31
@dearlordylord dearlordylord changed the title Managed Service Kebabs Feat: Managed Service Kebabs Mar 17, 2025
@dearlordylord dearlordylord changed the title Feat: Managed Service Kebabs feat: Managed Service Kebabs Mar 17, 2025
@dearlordylord dearlordylord force-pushed the feat/managed-servide-provider-dictionary branch from b5bbc92 to ff8352c Compare March 17, 2025 19:45
@dearlordylord dearlordylord force-pushed the feat/managed-servide-provider-dictionary branch 2 times, most recently from a25bfff to 654e54b Compare March 17, 2025 20:38
@coveralls
Copy link
Collaborator

coveralls commented Mar 17, 2025

Pull Request Test Coverage Report for Build 14097016956

Details

  • 53 of 55 (96.36%) changed or added relevant lines in 11 files are covered.
  • 44 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+15.7%) to 96.23%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scope3ai/constants.py 30 31 96.77%
scope3ai/lib.py 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
scope3ai/tracers/huggingface/chat.py 1 98.82%
scope3ai/tracers/huggingface/speech_to_text.py 1 98.18%
scope3ai/tracers/huggingface/translation.py 2 96.49%
scope3ai/api/tracer.py 3 93.75%
scope3ai/worker.py 3 89.58%
scope3ai/tracers/anthropic/chat.py 4 97.06%
scope3ai/tracers/openai/chat.py 4 96.46%
scope3ai/tracers/litellm/chat.py 6 95.31%
scope3ai/api/client.py 9 85.48%
scope3ai/lib.py 11 94.74%
Totals Coverage Status
Change from base Build 12553763769: 15.7%
Covered Lines: 2578
Relevant Lines: 2679

💛 - Coveralls

@dearlordylord dearlordylord force-pushed the feat/managed-servide-provider-dictionary branch from 654e54b to c0d3ecf Compare March 26, 2025 19:06
@dearlordylord dearlordylord force-pushed the feat/managed-servide-provider-dictionary branch from c0d3ecf to 76457f5 Compare March 26, 2025 19:20
@dearlordylord
Copy link
Contributor Author

discovered architectural problem: it seems that currently it's not possible to tell whether it's gemini or vertex call from the monkeypatched functions (at least without result analysis)

@dearlordylord dearlordylord merged commit 64d309a into main Mar 27, 2025
19 checks passed
@dearlordylord dearlordylord deleted the feat/managed-servide-provider-dictionary branch March 27, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants